-
Notifications
You must be signed in to change notification settings - Fork 47
Merge Parallel Trace Abstraction into Dev #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxBarth95
wants to merge
277
commits into
dev
Choose a base branch
from
merge/mb/parallel-trace-abstraction
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Va for reuse is the last in the trace and contains all inputs
…name as the current branch. Readded UnsatWith to prevent unnecessary sat checks
deactivated unsatwith fixed that there is no otherbranch optimication if reusing negated va
Deactivated negated reuse, seems to help with hostid benchmark
- Fixed bounds of signed c types in testexporter - enabled unproen testgeneration result for timeouts
…ince it was no longer used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
I prepared this branch to merge my parallel trace abstraction approach into main.
Feel free to take a look already, make suggestions, and ideally tell me how you want it to be refactored.
Unfortunately my changes affects quite a few classes.
Before merging, I need to run a few more experiments to ensure there are no unwanted side effects.
The following changes have been made:
ParallelNwaCegarLoop.java
Contains the main CEGAR loop
CegarNwaWorkerThread.java
Is the corresponding class that does the trace check, interpolation, and generalization of the resulting automaton
Some changes are made to the refinement strategy stuff. In the CegarNwaWorkerThread.java I can for example
(se commented code) decide to do LoopAcceleration after seeing a PathProgram 7 times.
IsEmptyParallel
The search now searches for a Prefix of a counterexamples that is different from all counterexamples in a Set given as parameter. Then IsEmptyHeuristic is called with waypoints. Those waypoints are the Prefix and the IsEmptyHeuristic search follows those waypoints and after the last waypoints it searches for an accepting state.
It will not backtrack beyond the last waypoint.
TransferBetweenMainAndWorker
This is now the more elegant solution to our script problem. Each worker has one such transfer class and it manages all transfers in both direction. It transfers the CfgSmtToolkit, Automata, Counterexamples. To be precise, transformulas, IProgramVars everything that the CFGSmtToolkit touches
Wintesses
To create a violation witness i need the sort of a value in the TypeSortTranslator. This sorts come from worker smtcfgtoolkit scripts. Since the TypeSortTranslator is created at the very start when translating to Boogie. I need a way to tell the TypeSortTranslator what the script is, that created this sort. I do this by passing it through the programexecution